-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: markets page APY range select #2288
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Thirteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
859.29 KB (🟡 +1.32 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Thirteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
50.38 KB (🟢 -2.28 KB) |
909.68 KB |
/404 |
5.08 KB (🟢 -2.31 KB) |
864.38 KB |
/500 |
5.5 KB (🟢 -2.31 KB) |
864.79 KB |
/bridge |
37.51 KB (🟢 -2.31 KB) |
896.8 KB |
/faucet |
17.52 KB (🟢 -2.31 KB) |
876.81 KB |
/governance |
85.38 KB (🟢 -2.3 KB) |
944.67 KB |
/governance/ipfs-preview |
102.84 KB (🟢 -2.31 KB) |
962.14 KB |
/governance/v3/proposal |
128.71 KB (🟢 -2.31 KB) |
988 KB |
/history |
26.17 KB (🟢 -2.31 KB) |
885.47 KB |
/markets |
32.66 KB (🟢 -795 B) |
891.95 KB |
/reserve-overview |
24.04 KB (🟢 -2.31 KB) |
883.33 KB |
/staking |
36 KB (🟢 -2.31 KB) |
895.29 KB |
/v3-migration |
34.36 KB (🟢 -2.28 KB) |
893.65 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
General Changes
selectedTimeRange
to root storeMarketsAssetsList
based onselectedTimeRange
Historical Rate Logic
The implied APY for a selected time-frame is calculated by comparing the growth in supply (
liquidityIndex
) or borrow (variableBorrowIndex
) indeces over the selected time range, and scaling the growth to a timescale of one year:impliedAPY = (endIndex / startIndex)^(365 / timeRange) - 1
Subgraph Queries
Protocol subgraphs are event-driven, to account for this the most recent reserve update and the update closest to the historical timestamps are queried to very closely approximate the
startIndex
andendIndex
.The subgraph query works by concatenating a request to fetch the current and previous index for each individual
underlyingAsset
, and exeucting them as a single network request.Any reserve which was listed after the selected time range will not display a historic rate (i.e. if reserve was added 50 days ago it will not have a historic APY for the 60 day time range and beyond).